Skip to content

Properly relight surrounding chunks#3147

Merged
SirYwell merged 1 commit intomainfrom
fix/light-bordering-chunks
Mar 22, 2025
Merged

Properly relight surrounding chunks#3147
SirYwell merged 1 commit intomainfrom
fix/light-bordering-chunks

Conversation

@SirYwell
Copy link
Copy Markdown
Member

Overview

Fixes #3145

Description

We need to make sure chunks bordering a change are relighted too, as light could spread into them. By just enqueuing 3x3 chunks, light is always properly recalculated now.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner March 12, 2025 16:01
@github-actions github-actions Bot added the Bugfix This PR fixes a bug label Mar 12, 2025
@dordsor21 dordsor21 requested a review from a team March 13, 2025 16:19
@SirYwell SirYwell merged commit f03e16c into main Mar 22, 2025
9 checks passed
@SirYwell SirYwell deleted the fix/light-bordering-chunks branch March 22, 2025 16:25
@zechatmachine-hub
Copy link
Copy Markdown

zechatmachine-hub commented Feb 1, 2026

hi,
i still got the issue on 2.15.0
image

close to the pasted zone the block in my hand is lighted
image
just a bit farther to the pasted zone the block in my hand is not lighted anymore
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lighting not being propagated in chunks bordering the pasted region

4 participants